Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out start-a-libp2p-daemon! #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Factor out start-a-libp2p-daemon! #21

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aef0a7e
Factor out start-a-libp2p-daemon!
AlexKnauth Mar 10, 2022
3f74939
Rename start-libp2p-daemon -> start-the-libp2p-daemon!
AlexKnauth Mar 12, 2022
60dc933
Document new libp2p-daemon functions
AlexKnauth Mar 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libp2p.ss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
;; :vyzo/libp2p/daemon
current-libp2p-daemon
start-libp2p-daemon!
start-a-libp2p-daemon!
stop-libp2p-daemon!
stop-the-libp2p-daemon!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it start-a- and stop-the- ?

Copy link
Contributor Author

@AlexKnauth AlexKnauth Mar 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If backwards compatibility is a concern,
Current behavior has:

  • start-libp2p-daemon! for "the" daemon in current-libp2p-daemon
  • stop-libp2p-daemon! for "a" daemon, where current-libp2p-daemon doesn't matter

A better design would have:

  • start-libp2p-daemon! for "a" daemon
  • stop-libp2p-daemon! for "a" daemon
  • start-the-libp2p-daemon! for "the" daemon in current-libp2p-daemon
  • stop-the-libp2p-daemon! for "the" daemon in current-libp2p-daemon

The closest thing I could think of to that while maintaining backwards compatibility has:

  • start-a-libp2p-daemon! for "a daemon"
  • stop-libp2p-daemon! for "a" daemon as dictated by existing code
  • start-libp2p-daemon! for "the" daemon as dictated by existing code
  • stop-the-libp2p-daemon! for "the" daemon in current-libp2p-daemon

If backwards compatibility is not a concern, I could make it more consistent with only "the" and no "a", but I won't do that unless @vyzo says that's what he wants.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've changed the convention to make it more consistent with only "the" and no "a", and also added some documentation.

use-libp2p-daemon!
;; :vyzo/libp2p/client
libp2p-error?
Expand Down
21 changes: 19 additions & 2 deletions libp2p/daemon.ss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
(def current-libp2p-daemon
(make-parameter #f))

;; Starts a new libp2p-daemon only if there is no existing current-libp2p-daemon,
;; and if so sets the current-libp2p-daemon to the new one.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that should be renamed ensure-libp2p-daemon ?
Or, if we want backward-compatibility, a force: or new: boolean flag?

(def (start-libp2p-daemon! host-addresses: (host-addrs #f) daemon: (bin "p2pd")
options: (args [])
address: (sock #f)
Expand All @@ -22,6 +24,18 @@
((current-libp2p-daemon)
=> values)
(else
(let ((d (start-a-libp2p-daemon! host-addresses: host-addrs daemon: bin
options: args
address: sock
wait: timeo)))
(current-libp2p-daemon d)
d))))

;; Starts a libp2p-daemon without regard to current-libp2p-daemon
(def (start-a-libp2p-daemon! host-addresses: (host-addrs #f) daemon: (bin "p2pd")
options: (args [])
address: (sock #f)
wait: (timeo 0.4))
(let* ((path (or sock (string-append "/tmp/p2pd." (number->string (getpid)) ".sock")))
(addr (string-append "/unix" path))
(proc (if host-addrs
Expand All @@ -32,8 +46,7 @@
((process-status proc timeo #f)
=> (lambda (status)
(error "p2pd exited prematurely" status))))
(current-libp2p-daemon d)
d))))
d))

(def (stop-libp2p-daemon! (d (current-libp2p-daemon)))
(with ((daemon proc path) d)
Expand All @@ -45,5 +58,9 @@
(delete-file path))
status))))

(def (stop-the-libp2p-daemon!)
(stop-libp2p-daemon!)
(current-libp2p-daemon #f))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't stop-libp2p-daemon! always call (current-libp2p-daemon #f) ? And then this function becomes unnecessary?


(def (use-libp2p-daemon! path)
(current-libp2p-daemon (daemon #f path)))