Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add idPrefix to symbol generator #89

Closed
wants to merge 2 commits into from

Conversation

mistersender
Copy link

idPrefix has been added as an option for the generator. It will prepend the specified string to each id on the symbol.

@w0rm
Copy link
Owner

w0rm commented May 21, 2018

Hi! To prefix ids, please use gulp-rename as written in the readme: https://github.com/w0rm/gulp-svgstore#generating-id-attributes

I've considered this option, but this goes against gulp plugin guidelines

  1. Your plugin should only do one thing, and do it well.
  2. Your plugin shouldn't do things that other plugins are responsible for

@w0rm w0rm closed this May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants