Fix entries always using value read, not absolute (#35)

Co-authored-by: Ramon <ramon.guimera@skyscanner.net>

finance_tracker/entries/entry.py

@@ -28,11 +28,17 @@ def month_from_date_of_action(self) -> int:
 
     @classmethod
     def from_revolut_entry(cls, revolut_entry: RevolutEntry):
+        """
+        Returns an entry from a RevolutEntry. Values not recognized or not being in RevolutEntry will be created
+        with default values.
+        :param revolut_entry: RevolutEntry to obtain data from
+        :return: Entry from a RevolutEntry
+        """
         return cls(
             entry_date=revolut_entry.started_date_for_entry(),
             date_of_action=revolut_entry.completed_date_for_entry(),
             title=revolut_entry.description,
             other_data="",
-            quantity=revolut_entry.quantity_as_absolute(),
+            quantity=revolut_entry.quantity(),
             balance=revolut_entry.balance_as_money(),
         )

finance_tracker/entries/revolut_entry.py

@@ -1,6 +1,8 @@
 from dataclasses import dataclass
 from datetime import date, datetime
 
+from deprecated.classic import deprecated
+
 from finance_tracker.money.currency_codes import CurrencyCodes
 from finance_tracker.money.money import Money
 
@@ -19,8 +21,14 @@ class RevolutEntry:
     balance: float
 
     def quantity(self) -> Money:
+        """
+        Returns the quantity of this entry as a Money object composed of
+        the same amount and currency code from its currency.
+        :return: Money from amount and currency
+        """
         return Money(amount=self.amount, currency_code=CurrencyCodes[self.currency])
 
+    @deprecated(reason="Use quantity. Entries use the value its read, no absolute.", version="1.1.0")
     def quantity_as_absolute(self) -> Money:
         return Money(amount=abs(self.amount), currency_code=CurrencyCodes[self.currency])
 

tests/entries/test_entry.py

@@ -31,5 +31,5 @@ def test_entry_from_revolut_entry(revolut_entry):
     assert entry.date_of_action_as_time() == date(day=3, month=10, year=2022)
     assert entry.title == "Supermarket purchase"
     assert entry.other_data == ""
-    assert entry.quantity == Money(amount=4, currency_code=CurrencyCodes.EUR)
+    assert entry.quantity == Money(amount=-4, currency_code=CurrencyCodes.EUR)
     assert entry.balance == Money(amount=100, currency_code=CurrencyCodes.EUR)