-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to 1.1.9 breaks due to "Cannot read property 'offsetTop' of undefined". #53
Comments
I came across this issue as well with the update. Need to check that angular-sticky-things/projects/angular-sticky-things/src/lib/sticky-thing.directive.ts Line 225 in f3bfae6
Great project! |
I did manage to make it work again by setting a boundary element, however I still got the same error message. Not sure if it is because I have some |
@ramtennae @yahmez00 thanks for the hint and for using our library. i've fixed the issue. will release a new version later tomorrow. |
@ramtennae @yahmez00 published new version 1.2.1 - should fix the problem. |
1.2.1 fixed it, thanks! |
Hey there,
We've been using StickyThings in our app for a little while, and it was working great. However with the recent upgrade from 1.1.2 to 1.1.9, I get the following error and the sticky no longer works:
I noticed if I have the
scrollContainer
property set then that error disappears, however the sticky no longer works. I've put theclass="scroll-container"
in a bunch of places but to no avail.Going by the documentation a scroll container shouldn't be required (it wasn't for 1.1.2)? Any help would be great. Thanks for your hard work!
The text was updated successfully, but these errors were encountered: