remove unused comment

w180112 · Nov 11, 2023 · 540f421 · 540f421
1 parent c9dfb40
commit 540f421
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/pppd/codec.c b/src/pppd/codec.c
@@ -187,16 +187,15 @@ STATUS PPP_decode_frame(tVRG_MBX *mail, struct rte_ether_hdr *eth_hdr, vlan_head
 	else if (ppp_payload->ppp_protocol == rte_cpu_to_be_16(PAP_PROTOCOL)) {
 		if (s_ppp_ccb->phase != AUTH_PHASE)
 			return ERROR;
-		//ppp_pap_ack_nak_t ppp_pap_ack_nak, *tmp_ppp_pap_ack_nak = (ppp_pap_ack_nak_t *)(tmp_ppp_hdr + 1);
-		//rte_memcpy(&ppp_pap_ack_nak,tmp_ppp_pap_ack_nak,tmp_ppp_pap_ack_nak->msg_length + sizeof(U8));
+		// we don't care what msg pap server send to us, just check it's ack or nak
 		if (ppp_hdr->code == PAP_ACK) {
 			VRG_LOG(INFO, vrg_ccb->fp, s_ppp_ccb, PPPLOGMSG, "User %" PRIu16 " auth success.", s_ppp_ccb->user_num);
 			s_ppp_ccb->phase = IPCP_PHASE;
 			return TRUE;
 		}
 		else if (ppp_hdr->code == PAP_NAK) {
     		s_ppp_ccb->phase = LCP_PHASE;
-    		PPP_FSM(&(s_ppp_ccb->ppp),s_ppp_ccb,E_CLOSE);
+    		PPP_FSM(&(s_ppp_ccb->ppp), s_ppp_ccb, E_CLOSE);
 			VRG_LOG(WARN, vrg_ccb->fp, s_ppp_ccb, PPPLOGMSG, "User %" PRIu16 " auth fail.", s_ppp_ccb->user_num);
 			return TRUE;
 		}

diff --git a/src/pppd/fsm.h b/src/pppd/fsm.h
@@ -53,7 +53,7 @@ typedef enum {
 	E_RECV_GOOD_CODE_PROTOCOL_REJECT,
 	E_RECV_BAD_CODE_PROTOCOL_REJECT,
 	E_RECV_ECHO_REPLY_REQUEST_DISCARD_REQUEST,
-	E_UNKNOWN,
+	E_UNKNOWN, // for log usage, not for fsm
 } PPP_EVENT_TYPE;
 
 typedef enum {