Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/wagmi rainbow viem #150

Conversation

diegosano
Copy link
Contributor

  • Install RainbowKit package
  • Upgrade wagmi, viem and next
  • Add Wagmi and RainbowKit providers to layout
  • Refactor tasks service hook to use Viem instead of Ethers.js

Copy link
Member

@heronlancellot heronlancellot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR @diegosano ! Some adjustments that I could see to merge it for now

  • Remove contract address from env
  • Remove .vscode configurations
  • Remove pino-pretty
  • Remove TaskFront for now ( let's handle that after !! )
  • Refactor get the boilerplate inspired to handle differents networks in Task-Service

src/contracts/web3taskABI.ts Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
.env.example Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, can you please remove the pino-pretty configuration from next.config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pino-pretty in next.config.js is to resolve this issue with RainbowKit:
WalletConnect/walletconnect-monorepo#1908

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think don't need set from now the we had some issues with that before, have TaskFront & Task, let's handle that after !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added type to useState to stop the type errors in the file, since the two states are initialized with null, the respective sets is breaking when called

src/services/tasks-service.ts Show resolved Hide resolved
@diegosano
Copy link
Contributor Author

@heronlancellot added more comments and refactor the dynamic addresses from contracts

Copy link
Member

@heronlancellot heronlancellot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @diegosano ! Niceee update
thankss

@heronlancellot heronlancellot merged commit ff8b505 into w3b3d3v:16-refactor-next-react-rainbow-tailwind-wagmi-viem Nov 23, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants