Conversation
Thanks for your submission. I reviewed your draft DID method specification. A few comments:
Thanks. |
Thanks for your support. |
Wait a sec, @OmniOneID ... you closed the pull request w/o it being merged. Is that what you intended to do? |
Closing was not what i intended, sorry. I reopend this pull request. |
This addresses everything in my original comment except one thing: you removed the "Delete" method but now there's nothing (that I saw) that addresses the "Delete" or "Deactivate" operation that all DID method specifications are required to specify. So your spec should say how a DID & DID document can be either deleted or deactivated so the DID is effectively terminated/revoked—and cannot be unterminated or unrevoked. If you can add a section specifying how your method accomplishes that operation, then it should be good to go. Note that some other methods accomplish deactivation by writing a null DID document, and then specifying that that operation cannot be undone, and no further operations can be performed on that DID. |
I've specified the delete operation on our did specification. |
Just for the record, there's been discussion whether certain special-purpose DID methods may not support Update or Delete (see w3c-ccg/did-spec#55). This is an open question, but in any case, good to see that OmniOne supports all operations. |
@peacekeeper has a good point. However in this case it doesn't matter as you have specified a Delete method. I'm satisfied now and support accepting this. |
What should I do to complete the pull request? |
Fix the merge conflicts. |
There are no conflicts now. |
Please confirm that the pull request has been completed? |
Conflicts remain, please fix. |
There are still conflicts, please fix the conflicts so we can merge this in. |
Would you please check my fix and complete this pull request? |
This pull request is for adding the OmniOne DID Method Specification.