Skip to content
This repository has been archived by the owner on Aug 12, 2020. It is now read-only.

Add OmniOne DID Method #42

Merged
merged 3 commits into from Oct 16, 2019
Merged

Add OmniOne DID Method #42

merged 3 commits into from Oct 16, 2019

Conversation

OmniOneID
Copy link
Contributor

This pull request is for adding the OmniOne DID Method Specification.

@talltree
Copy link

talltree commented May 10, 2019

Thanks for your submission. I reviewed your draft DID method specification. A few comments:

  • Check the formatting of your ABNF; it's not coming across as code.
  • You don't specify what happens in the Delete operation, i.e., what does the proof do, and what's the end result. Can a DID document be "undeleted"? (The answer should be no.)
  • You need to finish the Security and Privacy Consideration sections before we can accept the PR. (Too many early submissions left these blank.)

Thanks.

@OmniOneID
Copy link
Contributor Author

OmniOneID commented May 29, 2019

  • checked ABNF
  • removed delete operation
  • updated both security and privacy sections of our DID method document.

Thanks for your support.

@OmniOneID OmniOneID closed this May 29, 2019
@msporny
Copy link
Contributor

msporny commented May 29, 2019

Wait a sec, @OmniOneID ... you closed the pull request w/o it being merged. Is that what you intended to do?

@OmniOneID
Copy link
Contributor Author

OmniOneID commented May 30, 2019

Closing was not what i intended, sorry. I reopend this pull request.
Thank you

@OmniOneID OmniOneID reopened this May 30, 2019
@talltree
Copy link

This addresses everything in my original comment except one thing: you removed the "Delete" method but now there's nothing (that I saw) that addresses the "Delete" or "Deactivate" operation that all DID method specifications are required to specify.

So your spec should say how a DID & DID document can be either deleted or deactivated so the DID is effectively terminated/revoked—and cannot be unterminated or unrevoked. If you can add a section specifying how your method accomplishes that operation, then it should be good to go.

Note that some other methods accomplish deactivation by writing a null DID document, and then specifying that that operation cannot be undone, and no further operations can be performed on that DID.

@OmniOneID
Copy link
Contributor Author

I've specified the delete operation on our did specification.
Thank you for your help.

@peacekeeper
Copy link
Member

the "Delete" or "Deactivate" operation that all DID method specifications are required to specify.

Just for the record, there's been discussion whether certain special-purpose DID methods may not support Update or Delete (see w3c-ccg/did-spec#55). This is an open question, but in any case, good to see that OmniOne supports all operations.

@talltree
Copy link

@peacekeeper has a good point. However in this case it doesn't matter as you have specified a Delete method. I'm satisfied now and support accepting this.

@OmniOneID
Copy link
Contributor Author

What should I do to complete the pull request?

@msporny
Copy link
Contributor

msporny commented Jun 10, 2019

What should I do to complete the pull request?

Fix the merge conflicts.

@OmniOneID
Copy link
Contributor Author

There are no conflicts now.

@OmniOneID
Copy link
Contributor Author

Please confirm that the pull request has been completed?

@msporny
Copy link
Contributor

msporny commented Jul 16, 2019

There are no conflicts now.

Conflicts remain, please fix.

@msporny
Copy link
Contributor

msporny commented Oct 11, 2019

There are no conflicts now.
Conflicts remain, please fix.

There are still conflicts, please fix the conflicts so we can merge this in.

@OmniOneID
Copy link
Contributor Author

Would you please check my fix and complete this pull request?

@msporny msporny merged commit 0767e65 into w3c-ccg:gh-pages Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants