This repository has been archived by the owner on Oct 29, 2019. It is now read-only.
Add examples for path, query, and fragment. #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljones15
requested review from
msporny,
peacekeeper and
talltree
as code owners
talltree
reviewed
Jun 13, 2019
index.html
Outdated
| { | ||
| "id": "did:urn:example:id/path?query=true#service" | ||
| } | ||
| did:example:123456#service" |
There was a problem hiding this comment.
"service" may not be the best example of a fragment here because it overlaps with the "service=" matrix parameter. Could we use another standard property? Maybe authentication?
There was a problem hiding this comment.
Perhaps one from the example here: https://w3c-ccg.github.io/did-spec/#example-16-advanced-did-document-example, e.g. #oidc or #vcStore. or #hub.
There was a problem hiding this comment.
I changed it to #oidc.
peacekeeper
approved these changes
Jun 15, 2019
peacekeeper
added a commit
that referenced
this pull request
Jun 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds examples for sections
Address issue: #222
Preview | Diff