feat: add bbs bls signature and key definitions #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OR13
reviewed
Jul 29, 2020
OR13
reviewed
Jul 29, 2020
OR13
reviewed
Jul 29, 2020
| </p> | ||
| <pre class="example prettyprint language-jsonld"> | ||
| { | ||
| "@context": ["https://w3id.org/security/v1", "http://json-ld.org/contexts/person.jsonld"] |
There was a problem hiding this comment.
is this example correct? I would expect to see your context here.
There was a problem hiding this comment.
Was just following the pattern of JsonWebSignature2020, should I amend both?
There was a problem hiding this comment.
Im not sure... I feel like a registry should always have examples that are as accurate as possible, but we're obviously still in the middle of cleaning up security vocab.... I think for now, leave it off, and just work really hard to get it into sec context v3 so we can do a big pass updating all these examples.
OR13
approved these changes
Jul 29, 2020
|
This is pr against unstable, merging, names may change in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the definitions for the BBS+ signatures and associated keys documented here
Requires merging of w3c/vc-di-bbs#34 and w3c-ccg/ld-cryptosuite-registry#35