Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should /credentials/verify require a vc in the request body? #360

Closed
brownoxford opened this issue Aug 18, 2022 · 1 comment · Fixed by #385
Closed

Should /credentials/verify require a vc in the request body? #360

brownoxford opened this issue Aug 18, 2022 · 1 comment · Fixed by #385
Assignees

Comments

@brownoxford
Copy link
Collaborator

Currently, the verifiableCredential property in the request body for /credentials/verify requests is not required (see credential-verifier.yml)

The schema should be modified to require a value for verifiableCredential.

Current Schema

        schema:
          type: object
          properties:
            verifiableCredential:
              $ref: "../schemas/SerializedVerifiableCredential.yml"

Proposed Schema

        schema:
          type: object
          required:
            - verifiableCredential
          properties:
            verifiableCredential:
              $ref: "../schemas/SerializedVerifiableCredential.yml"
@brownoxford brownoxford self-assigned this Sep 6, 2022
@nissimsan
Copy link
Collaborator

Consensus on doing this on the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants