Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROPOSAL: We will use OAS3.0 YAML Schemas in trace vocab, instead of JSON Schema in JSON #186

Closed
OR13 opened this issue Jul 27, 2021 · 4 comments
Assignees

Comments

@OR13
Copy link
Collaborator

OR13 commented Jul 27, 2021

This proposal has not been resolved.

We have deferred this proposal to next meeting, and the issue is opened to gather feedback on exactly what such a change would look like.

As you can see, OAS 3.0 provides examples in JSON and YAML:

Here is an example of a Verifiable Credential Schema in OAS3.0 represented as YAML

Here is an example of a Verifiable Credential Schema in JSON Scheam with $comment

This proposal would be to convert all files in https://github.com/w3c-ccg/traceability-vocab/tree/main/packages/traceability-schemas/schemas to YAML which supports comments, and to ensure that they are 100% going to be compatible with vc-http-api.

@mkhraisha
Copy link
Collaborator

I was under the impression that OAS3.0 was mainly intended as a way to document web-apis, this however looks much cleaner than what we currently have. huge +1

@TallTed
Copy link
Contributor

TallTed commented Aug 2, 2021

If I understand this correctly, it seems that —

PROPOSAL: We will use OAS3.0 YAML Schemas in trace vocab, instead of JSON Schema in JSON.

— would be clearer and more internally consistent if rewritten as —

PROPOSAL: The trace vocab will use OAS3.0 Schemas represented in YAML, instead of JSON Schema represented in JSON.

?

@mprorock
Copy link
Collaborator

mprorock commented Nov 9, 2021

related to #189 - @mkhraisha would like this prior to a v1

@mprorock
Copy link
Collaborator

mprorock commented Nov 9, 2021

dupe #189

@mprorock mprorock closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants