chore: replace w3id.org #DateTime types with w3.org #dateTime types #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhofvendahl
requested review from
mkhraisha,
mprorock and
OR13
as code owners
OR13
reviewed
Dec 13, 2021
| "title": "dateOfEntry", | ||
| "description": "Date when the the package entered the port of entry.", | ||
| "type": "string" | ||
| }, | ||
| "signatureDate": { | ||
| "$comment": "{\"term\": \"signatureDate\", \"@id\": \"https://w3id.org/traceability#signatureDate\", \"@type\": \"https://w3id.org/traceability#DateTime\"}", | ||
| "$comment": "{\"term\": \"signatureDate\", \"@id\": \"https://w3id.org/traceability#signatureDate\", \"@type\": \"http://www.w3.org/2001/XMLSchema#dateTime\"}", |
There was a problem hiding this comment.
I question why we have this here... and why its not the issuanceDate or proof.created values... this is why Credential Types are needed not just JSON-LD Class types... still its orthogonal to the purpose of this PR.
There was a problem hiding this comment.
My understanding is this is a 1-1 from a physical document, I could be wrong though
OR13
approved these changes
Dec 13, 2021
mkhraisha
approved these changes
Dec 14, 2021
mprorock
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all 6 instances of
\"@type\": \"https://w3id.org/traceability#DateTime\"with\"@type\": \"http://www.w3.org/2001/XMLSchema#dateTime\", as specified in #213.