Update organizationName to name in PostalAddress #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change organizationName to name in the PostalAddress Object. The organizationName is not generic enough to represent all objects that use Postal Address object. They are not necessarely organizations as they can represent any entity. For example, Schema.org uses name inside the Postal Address schema.
Ralhusban
requested review from
OR13,
mprorock,
mkhraisha and
nissimsan
as code owners
OR13
approved these changes
Aug 9, 2022
mkhraisha
approved these changes
Aug 9, 2022
nissimsan
approved these changes
Aug 16, 2022
|
@Ralhusban, reminder to re-proof the certificates to make the checks pass. When you change the term definition, you break the credential signatures where PostalAdr is used. |
mprorock
approved these changes
Aug 16, 2022
|
CI must be passing prior to merging |
|
This PR was replaced by PR #533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change organizationName to name in the PostalAddress Object. The organizationName is not generic enough to represent all objects that use Postal Address object. They are not necessarely organizations as they can represent any entity. For example, Schema.org uses name inside the Postal Address schema.