Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GS1 gtin8 license credential #675

Merged
merged 6 commits into from
Jan 5, 2023
Merged

GS1 gtin8 license credential #675

merged 6 commits into from
Jan 5, 2023

Conversation

nissimsan
Copy link
Collaborator

nissimsan and others added 4 commits January 3, 2023 10:52
@nissimsan @TallTed
Update docs/openapi/components/schemas/credentials/GS18PrefixLicenseC…
db65513 
…redentialyml

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@nissimsan @TallTed
Update docs/openapi/components/schemas/credentials/GS18PrefixLicenseC…
a060fb2 
…redentialyml

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@nissimsan
fix: title gs1-8
000c441
@nissimsan
fix: gtin8-specific descr
e2be7bb
mkhraisha
mkhraisha requested changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@mkhraisha mkhraisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file extension isn't working? you may have put yml instead of .yml

@nissimsan
Copy link
Collaborator Author

@nissimsan to merge offline once the file extension bug is fixed.

mkhraisha
mkhraisha approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@mkhraisha mkhraisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Extension changed

@paulfdietrich
Copy link

@nissimsan. I did verify against the data model and this looks correct.

@nissimsan
Copy link
Collaborator Author

Fixed. Good catch, @mkhraisha - thanks!
Merging.

@nissimsan nissimsan merged commit f2aa538 into main Jan 5, 2023
@nissimsan nissimsan deleted the gtin8-cred branch January 17, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed left review comments

@mkhraisha mkhraisha mkhraisha approved these changes

@BenjaminMoe BenjaminMoe BenjaminMoe approved these changes

@OR13 OR13 Awaiting requested review from OR13 OR13 is a code owner

@mprorock mprorock Awaiting requested review from mprorock mprorock is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nissimsan @paulfdietrich @TallTed @mkhraisha @BenjaminMoe