Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Syntax for credential Schema #768

Merged
merged 4 commits into from
May 10, 2023
Merged

Update Syntax for credential Schema #768

merged 4 commits into from
May 10, 2023

Conversation

BenjaminMoe
Copy link
Collaborator

Syntax sugar updates to credentialSchema

  • example is a placeholder
  • default implies what the value should be
  • readonly sets form input to readonly for form libraries that support it

mkhraisha
mkhraisha requested changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@mkhraisha mkhraisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent issues

@mkhraisha mkhraisha merged commit a47a8b5 into main May 10, 2023
@BenjaminMoe BenjaminMoe deleted the credential-schema branch May 10, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OR13 OR13 OR13 approved these changes

@mkhraisha mkhraisha mkhraisha approved these changes

@nissimsan nissimsan nissimsan approved these changes

@mprorock mprorock Awaiting requested review from mprorock mprorock is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BenjaminMoe @OR13 @mkhraisha @nissimsan