Commercial invoice simplification #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminMoe
approved these changes
May 16, 2023
OR13
reviewed
May 16, 2023
| @@ -396,12 +395,12 @@ example: |- | |||
| } | |||
| } | |||
| }, | |||
| "consignee": { | |||
| "consignee": [{ | |||
There was a problem hiding this comment.
is this really a "multiple". field?
OR13
approved these changes
May 16, 2023
mprorock
approved these changes
May 16, 2023
| @@ -396,12 +395,12 @@ example: |- | |||
| } | |||
| } | |||
| }, | |||
| "consignee": { | |||
| "consignee": [{ | |||
There was a problem hiding this comment.
I suppose if we permit intermediates, but will need to signify ultimately who is final
mkhraisha
approved these changes
May 16, 2023
mkhraisha
approved these changes
May 16, 2023
BenjaminMoe
reviewed
May 16, 2023
| required: | ||
| - type | ||
| minItems: 0 | ||
| maxItems: 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inlines and simplifies and tightens up Commercial Invoice: