Openapi Workflow #797
Closed
Openapi Workflow #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
acarnagey
commented
Jun 2, 2023
•
acarnagey
commented
- Adds workflows to openapi paths
- Refactor paths into separate files
acarnagey
requested review from
OR13,
mprorock,
mkhraisha and
nissimsan
as code owners
nissimsan
approved these changes
Jun 5, 2023
BenjaminMoe
approved these changes
Jun 6, 2023
|
@acarnagey , could you add some more comments on this PR, pls? It isn't entirely clear on the call what is the effects of this. |
|
@acarnagey, suggestion to split this into two separate PRs. |
|
Also, @acarnagey, we recently removed the RDF classes from the respec:
Can you please remove that in the PR? |
mkhraisha
approved these changes
Jun 13, 2023
…napi-workflows # Conflicts: # docs/openapi/openapi.yml
OR13
reviewed
Jun 13, 2023
OR13
reviewed
Jun 13, 2023
|
Do not merge need to fix script that generates openapi.yml on npm i |
OR13
requested changes
Jun 13, 2023
OR13
reviewed
Jun 13, 2023
| @@ -8,11 +8,22 @@ const yaml = require('js-yaml'); | |||
| const Ajv = require('ajv').default; | |||
| const addFormats = require('ajv-formats').default; | |||
|
|
|||
| const schemaKeys = ['common', 'credentials', 'presentations', 'snippets']; | |||
There was a problem hiding this comment.
these are "components", but that is a nit
OR13
approved these changes
Jun 13, 2023
|
Closing this one out, the allOf in paths was causing additional validation errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.