Specify roles/components in endpoint steps for Supply Chain Import #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is currently defined, out of scope for the API, or does not exist but is in scope
|
There are some formatting issues but overall looks fine for our transition stage. Think we want to get to diagrams like the one attache |
jandrieu
requested changes
Jan 18, 2022
| <li>Holder (SMG) --> Holder App --> Verifier App: Notify ( GET /presentations/available ) </li> | ||
| <li>Holder App <-- Verifier App: return Domain & Challenge </li> | ||
| <li> {Holder App --> Holder Storage: get VCs ( out of scope )}</li> | ||
| <li> {Holder App --> Holder Storage and/or KMS: get keys ( out of scope )}</li> |
There was a problem hiding this comment.
I don't understand this one. Is it to the storage or to the KMS? And why are we getting keys? IMO, private keys should never be transmitted.
Suggested change
| <li> {Holder App --> Holder Storage and/or KMS: get keys ( out of scope )}</li> |
There was a problem hiding this comment.
it was in the diagram from your meeting with them, but omitted in the corresponding use-case. i wasn't at the meeting so I have no context
Co-authored-by: Joe Andrieu <joe@andrieu.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff