Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beware of broken revocation list urls #236

Closed
OR13 opened this issue Oct 26, 2021 · 2 comments
Closed

Beware of broken revocation list urls #236

OR13 opened this issue Oct 26, 2021 · 2 comments
Assignees

Comments

@OR13
Copy link
Contributor

OR13 commented Oct 26, 2021

https://w3c-ccg.github.io/vc-http-api/fixtures/revocationList.json -> causes all credentials issued against this endpoint to fail to verify.

All test data needs to be regenerated to use: https://w3c-ccg.github.io/vc-api/fixtures/revocationList.json

although probably it should use a w3id.org base instead to fix this properly.

@OR13 OR13 changed the title Beware of broken URLS Beware of broken revocation list urls Oct 26, 2021
@clehner
Copy link
Member

clehner commented Oct 29, 2021

It looks like the revocation list credential revocationList.json should also be regenerated, as its id no longer matches its URL (which it should according to https://w3c-ccg.github.io/vc-status-rl-2020/#revocationlist2020credential).
Maybe revocationList.json (i.e. the whole fixtures/ directory) should be moved into https://github.com/w3c-ccg/vc-api-test-suite also, so it can be updated atomically with the test suite's test vectors?

@OR13
Copy link
Contributor Author

OR13 commented Mar 21, 2022

@clehner fixed this, assigning him and closing the issue.

@OR13 OR13 closed this as completed Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants