Regenerate revocation list credential for new URL #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clehner
requested review from
mkhraisha,
msporny,
OR13 and
peacekeeper
as code owners
OR13
approved these changes
Nov 9, 2021
msporny
approved these changes
Nov 9, 2021
| @@ -18,9 +18,9 @@ | |||
| }, | |||
| "proof": { | |||
| "type": "Ed25519Signature2018", | |||
There was a problem hiding this comment.
Wondering what folks feelings are for switching to Ed25519Signature2020? We're all speed ahead at DB for that change because it switches to using multibase, which gets good compression in CBOR-LD, and because it makes a clean break from jws, which is what JsonWebSignature2020 is for.
|
This PR is ready for merge. |
msporny
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #236
A corresponding PR to update the verifiable credentials using the revocation list is here: w3c-ccg/vc-api-test-suite#10.
This uses a new key I generated locally, as I have not access to the existing key. Is this a correct approach?