Fix small mistake in description #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OR13
approved these changes
Aug 31, 2021
mkhraisha
approved these changes
Aug 31, 2021
msporny
approved these changes
Sep 6, 2021
OR13
approved these changes
Sep 13, 2021
mkhraisha
approved these changes
Sep 13, 2021
|
This appears to have all necessary approvals, looks ready to merge. |
|
CODEOWNERS: @peacekeeper @msporny @mavarley @OR13 @mkhraisha How many days do we leave a PR with only approvals open before merging? |
Not sure if we have ever defined a waiting period for PRs. In this case I think it's been open long enough, and it's a ridiculously small change :) Somehow I just didn't want to be the one to merge my own PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.