Performing changes for v0.3.2 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding intermediary step of multi language labels
remove foaf:Person and foaf:name substituted with vcard and schema.org annotation removed bnode fashion of stating contributors and creators
removal of foaf:name
…ision in future by language editors
Finalised multi language labels
Changed version IRIs according to #80
GeorgFerdinandSchneider
requested review from
maximelefrancois86 and
MadsHolten
|
My eye did not fall on any immediate issues content-wise. 🎉 Not sure if there are indentation guidelines for the ttl files in this project but I noticed there are inconsistencies in the indentation of the prefixes in these diffs. In order to lower merge conflicts it probably makes sense to ignore these and/or to use a single space after a |
|
@madnificent Thanks Aad for the comment! Good point with the indentation. I am not aware if there is any guideline for ttl. -> If merged to master the CI of Maxime recreates all files so may be the different indentation is not so much of an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of bot towards v0.3.2
-> revision of labels -> closes #90 #88 #87 #64 #47
-> removed FOAF -> closed #11
-> version iris changes -> closes #80