Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of definition bot:hasElement #88

Closed
mathib opened this issue Jul 20, 2020 · 4 comments
Closed

Update of definition bot:hasElement #88

mathib opened this issue Jul 20, 2020 · 4 comments
Assignees
@GeorgFerdinandSchneider
Labels
Revision of descriptions Revision of some definitions in bot according to discussions in related issues
Milestone
v0.3.2

Comments

@mathib
Copy link
Member

mathib commented Jul 20, 2020 •
edited by GeorgFerdinandSchneider
Loading

The text definition of bot:hasElement should have a minor update to include bot:intersectingElement cases (subproperty of bot:hasElement). Current definition:

Links a Zone to an Element that is either contained in or adjacent to, the Zone. The intended use of this relationship is not to be stated explicitly, but to be inferred from its sub-properties. It will, for example, allow one to query for all the doors of a building given that they have an adjacency to spaces of the building.

Proposal:

Links a Zone to an Element that is either contained in, adjacent to or intersecting with, the Zone. The intended use of this relationship is not to be stated explicitly, but to be inferred from its sub-properties. It will, for example, allow one to query for all the doors of a building given that they have an adjacency to spaces of the building.

An annoying detail is that all the translations would also need to be updated...
@maximelefrancois86
Copy link
Member

Yes, this makes perfect sense

@mathib
Copy link
Member Author

mathib commented Jul 20, 2020 •
edited by GeorgFerdinandSchneider
Loading

Moved comment by @mathib w.r.t bot:Zone to respective issue #87

@mathib mathib changed the title minor adjustment in bot:hasElement text definition minor adjustment in bot:hasElement and bot:Zone text definition Jul 20, 2020
Closed
@GeorgFerdinandSchneider GeorgFerdinandSchneider changed the title minor adjustment in bot:hasElement and bot:Zone text definition Update of definition bot:hasElement Jul 27, 2020
@GeorgFerdinandSchneider GeorgFerdinandSchneider added the Revision of descriptions Revision of some definitions in bot according to discussions in related issues label Jul 27, 2020
@GeorgFerdinandSchneider GeorgFerdinandSchneider added this to the v0.3.2 milestone Jul 27, 2020
@GeorgFerdinandSchneider
Copy link
Collaborator

GeorgFerdinandSchneider commented Jul 28, 2020 •
edited
Loading

Accepted by 28 July 2020

Closed
GeorgFerdinandSchneider added a commit that referenced this issue Jul 31, 2020
@GeorgFerdinandSchneider
Created file to preserve v0.3.1
33acb58 
added labels and comments as of 31/07/2020 pending #90 #88 #87 #47
Merged
@GeorgFerdinandSchneider
Copy link
Collaborator

closed by a460732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgFerdinandSchneider GeorgFerdinandSchneider

Labels
Revision of descriptions Revision of some definitions in bot according to discussions in related issues
Projects
None yet
Milestone
v0.3.2
Development

No branches or pull requests
3 participants
@maximelefrancois86 @GeorgFerdinandSchneider @mathib