Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added labels and comments #73

Merged
merged 7 commits into from
Jun 30, 2020

Conversation

MadsHolten
Copy link
Member

@MadsHolten
Copy link
Member Author

@maximelefrancois86 I have checked it with http://ttl.summerofcode.be/ and it throws no errors. Perhaps you can briefly evaluate the structure so we can go through it at the next meeting on Thursday.

@GeorgFerdinandSchneider
Copy link
Collaborator

Thanks Mads for leading this effort! I am in favour of adding labels and comments below.

I would suggest to not merge this request.

  1. In the spread sheet there is many fields empty marked with "Please ADD" e.g.:

"PLEASE ADD"@no ,
"PLEASE ADD"@tr ,

These should not be present and removed -> at best in the script these field should be ignored.

  1. with issues

Site: #54
Building: #65
Interface: #71
Storey: #66
hasSubElement: #47

the descriptions need to be updated first with these changes.

@maximelefrancois86
Copy link
Member

I agree with Georg

@GeorgFerdinandSchneider
Copy link
Collaborator

Related issues have been linked. We will await translations in https://docs.google.com/spreadsheets/d/1J5mEyblGU0M57XNpwQWxHbGlilRMzmCEqoU5FmOHILE/edit#gid=0 by contributors

hammar and others added 2 commits May 23, 2020 23:45
REC is modular and alignments are against entities in the Core and Building modules.
REC Alignment -- pegged REC version and added missing namespace
@GeorgFerdinandSchneider GeorgFerdinandSchneider merged commit 8877f62 into w3c-lbd-cg:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Revision of descriptions Revision of some definitions in bot according to discussions in related issues
Projects
None yet
4 participants