Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Web IDL changes to optional dictionary defaulting #134

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Update to Web IDL changes to optional dictionary defaulting #134

merged 2 commits into from
Jul 23, 2019

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jul 11, 2019 •
edited
Loading

This is part of whatwg/webidl#758

For normative changes, the following tasks have been completed:

  • Modified Web platform tests - IDL changes will be picked up automatically.

Implementation commitment:

The following bug needs to be fixed in Blink first:
https://bugs.chromium.org/p/chromium/issues/detail?id=984949

Preview | Diff

@marcoscaceres marcoscaceres mentioned this pull request Jul 11, 2019
Closed
56 tasks
mkruisselbrink
mkruisselbrink approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@mkruisselbrink mkruisselbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me.

@mkruisselbrink mkruisselbrink merged commit 7a0ed1d into master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkruisselbrink mkruisselbrink mkruisselbrink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcoscaceres @mkruisselbrink