Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction active flag needs to be set during upgradeneeded callback #163

Closed
inexorabletash opened this issue Mar 7, 2017 · 2 comments
Closed

Transaction active flag needs to be set during upgradeneeded callback #163

inexorabletash opened this issue Mar 7, 2017 · 2 comments
Assignees
@inexorabletash
Labels
needs-pr needs-tests
Milestone
V2

Comments

@inexorabletash
Copy link
Member

https://w3c.github.io/IndexedDB/#upgrade-transaction-steps

Steps should set/unset the active flag around the dispatch.

This was missing in V1, but implied by all of the machinery around transactions - whee. Also needs a test.
@inexorabletash inexorabletash added this to the V2 milestone Mar 7, 2017
@inexorabletash inexorabletash self-assigned this Mar 7, 2017
inexorabletash added a commit that referenced this issue Mar 7, 2017
@inexorabletash
Activate/deactivate transactions in upgradeneeded. For #163
5d1070b
@inexorabletash
Copy link
Member Author

Bundled fix with the related PR. Tests included in web-platform-tests/wpt#4643

@inexorabletash
Copy link
Member Author

Taken care of in 5ae70f2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inexorabletash inexorabletash

Labels
needs-pr needs-tests
Projects
None yet
Milestone
V2
Development

No branches or pull requests
1 participant
@inexorabletash