Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit about deleteDatabase error example #196

Closed
brettz9 opened this issue Apr 27, 2017 · 2 comments
Closed

Nit about deleteDatabase error example #196

brettz9 opened this issue Apr 27, 2017 · 2 comments
Labels

Comments

@brettz9
Copy link
Contributor

brettz9 commented Apr 27, 2017

For the recent addition for deleteDatabase stating:

Delete db. If this fails for any reason, return an appropriate error (e.g. "QuotaExceededError" or "UnknownError" DOMException).

...I am guessing that the use of "QuotaExceededError" was a carry-over from the open example as it wouldn't seem to me to be a valid error one would encounter on attempting to delete a database.

@brettz9 brettz9 changed the title Nit in deleteDatabase error example Nit about deleteDatabase error example Apr 27, 2017
@inexorabletash
Copy link
Member

Yes, it's copy/paste.

It's plausible if the implementation's backing store adds tombstones rather than immediately deleting information (as leveldb does). It'd be a poor implementation that didn't allow for deletes in this case, however (Chrome special cases delete-only transactions, etc to be "free")

@inexorabletash
Copy link
Member

I'm going to leave this as is, as I want to imply that "UnknownError" should be the last choice. This text is pretty squishy anyway ("appropriate error ... e.g. ..." in normative text?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants