Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronously executing a request should queue a task to fire events #83

Closed
nox opened this issue Jul 21, 2016 · 3 comments
Closed

Asynchronously executing a request should queue a task to fire events #83

nox opened this issue Jul 21, 2016 · 3 comments

Comments

@nox
Copy link
Contributor

nox commented Jul 21, 2016

As far as I understand, the steps to asynchronously execute a request run outside of the event loop from where the request was created. Given that fact, how can steps 8 and 9 respectively fire an error event and fire a success event?

@inexorabletash
Copy link
Member

Yep, that needs fixing.

Thank you very much for looking at the spec at this level of detail. V1 was even less precise and I'd really like to get v2 up to snuff. Your reports like this are incredibly helpful. Keep them coming!

@inexorabletash
Copy link
Member

Please take a look at the changes (I touched a few other algorithms that had "fire an event" from a non-event loop context)

It may be more precise (necessary?) to specify e.g. "...queue a task within the task source associated with the request/connection..." in these cases. Suggestions (or examples from other specs) of appropriate text is appreciated.

triple-underscore added a commit to triple-underscore/triple-underscore.github.io that referenced this issue Jul 22, 2016
@nox
Copy link
Contributor Author

nox commented Jul 23, 2016

This looks ok, thanks for the quick correction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants