Rework event dispatching #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proper event creation and 'dispatch' steps otherwise.
pwnall
reviewed
Mar 6, 2017
| must use the [=Event=] interface and set the | ||
| {{Event/type}} attribute to "<code>success</code>". The | ||
| event does not bubble and is not cancelable. If the steps | ||
| to |result| and [=fire an event=] named |
There was a problem hiding this comment.
Is this different from the "fire a success event" algorithm defined below?
There was a problem hiding this comment.
Yes, see the note just below this algorithm. "The firing of..."
There was a problem hiding this comment.
Thank you for clarifying! The GitHub edit window is too small... I'll review the changes with the HTML on the right.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 'fire an event' steps when easy, proper event creation and 'dispatch' steps otherwise.