Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cursor.request #257

Merged
merged 4 commits into from Mar 14, 2019
Merged

Add cursor.request #257

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e30732a
Add cursor.request
jakearchibald Mar 13, 2019
8549b81
Adding dev docs. Addressing nits.
jakearchibald Mar 13, 2019
1d711c7
Additional nits
jakearchibald Mar 14, 2019
03636c1
Silly me
jakearchibald Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 17 additions & 1 deletion index.bs
View file
Open in desktop
Expand Up @@ -4617,6 +4617,7 @@ interface IDBCursor {
readonly attribute IDBCursorDirection direction;
readonly attribute any key;
readonly attribute any primaryKey;
readonly attribute IDBRequest request;
inexorabletash marked this conversation as resolved.
Show resolved Hide resolved

void advance([EnforceRange] unsigned long count);
void continue(optional any key);
Expand Down Expand Up @@ -4657,12 +4658,16 @@ enum IDBCursorDirection {
Returns the [=cursor/effective key=] of the cursor.
Throws a "{{InvalidStateError}}" {{DOMException}} if the cursor is advancing or is finished.
</dd>
<dt><var>cursor</var> . {{IDBCursor/request}}
<dd>
Returns the [=cursor/request=] that was used to obtain this cursor.
</dd>
</dl>
</div>


The <dfn attribute for=IDBCursor>source</dfn> attribute's getter must
return the [=cursor/source=] of this [=cursor=]. This
return the [=cursor/source=] of the [=cursor=]. This
attribute never returns null or throws an exception, even if the
cursor is currently being iterated, has iterated past its end, or its
[=/transaction=] is not [=transaction/active=].
Expand Down Expand Up @@ -4690,6 +4695,15 @@ object is modified, those modifications will be seen by anyone
inspecting the value of the cursor. However modifying such an object
does not modify the contents of the database.

The <dfn attribute for=IDBCursor>request</dfn> attribute's getter must
return the [=cursor/request=] of the [=cursor=].

inexorabletash marked this conversation as resolved.
Show resolved Hide resolved
<aside class=advisement>
&#x1F6A7;
The {{IDBCursor/request}} attribute is new in this edition.
&#x1F6A7;
</aside>

<div class=note>
The following methods advance a [=cursor=]. Once the cursor has
advanced, a <a event>`success`</a> event will be fired at the
Expand Down Expand Up @@ -7184,6 +7198,7 @@ For the revision history of the second edition, see [that document's Revision Hi
* Updated [partial interface definition](#global-scope) since {{WindowOrWorkerGlobalScope}} is now a `mixin` ([PR #238](https://github.com/w3c/IndexedDB/pull/238)).
* Added {{IDBFactory/databases()}} method. ([Issue #31](https://github.com/w3c/IndexedDB/issues/31))
* Added {{IDBTransaction/commit()}} method. ([Issue #234](https://github.com/w3c/IndexedDB/issues/234))
* Added {{IDBCursor/request}} attribute. ([Issue #234](https://github.com/w3c/IndexedDB/issues/255))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Issue #255

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol


<!-- ============================================================ -->
# Acknowledgements # {#acknowledgements}
Expand All @@ -7204,6 +7219,7 @@ for his general authoring advice.

Special thanks to
Chris Anderson,
Jake Archibald,
Andreas Butler,
Pablo Castro,
Victor Costan,
Expand Down