Editorial: Use settings object definition. #330
Conversation
There was a problem hiding this comment.
Is this correct? As far as I can tell chrome uses the relevant settings object of |this|, not the current settings object (i.e. the ScriptState passed in by our bindings code is the result of calling ScriptState::ForRelevantRealm(info), and the rest of the IDB code then uses that to figure out origin, mojo interface broker, etc).
|
Ah, you're right, relevant is probably correct. (Aside: I need to understand why NFS is using a mix of current vs. relevant.) |
|
Relevant realm/settings object needs to be applied to a particular platform object (i.e. (which coincidently is also part of the reason of the mix of current and relevant in NFS, static methods like getSystemDirectory don't have a |this|/platform object, so relevant realm doesn't make sense in that context, hence why that uses the current settings object instead (which also matches what our bindings do for CallWith=ScriptState on static methods). Most of the other cases of current realm in NFS should probably be relevant though, I'll need to fix that...) |
* Use settings object definition. * Relevant settings object not, current * relevant to what? this
Closes #329
Use the formal definition for environment settings object rather than the imprecise "global scope used to access this".
No normative behavior changes, just being more precise.
Preview | Diff