Skip to content

Commit

Permalink
Editorial: Update link texts upon updates in the URLPattern specifica…
Browse files Browse the repository at this point in the history
…tion (#1707)

* Update link texts upon updates in the URLPattern specification

Updates in the URLPattern specification was requested during the
#1701 review.

The issues for the request has been resolved:
- whatwg/urlpattern#217
- whatwg/urlpattern#218

However, during the specification updates, the algorithm names are also
updated, and adjustment is needed.


Co-authored-by: Domenic Denicola <d@domenic.me>
  • Loading branch information
yoshisatoyanagisawa and domenic committed Mar 13, 2024
1 parent 613f5a2 commit e89eaed
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions docs/index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -3357,13 +3357,10 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
:: |rawPattern|, a {{URLPatternCompatible}}
:: |serviceWorker|, a [=/service worker=]
: Output
:: {{URLPattern}}
:: A [=URL pattern=]

1. Let |baseURL| be |serviceWorker|'s [=service worker/script url=].
1. Return the result of [=building a URLPattern from a Web IDL value=] |rawPattern| given |baseURL| and |serviceWorker|'s [=service worker/global object=]'s [=relevant realm=].

Note: Since the [=building a URLPattern from a Web IDL value=] algorithm actually do not depend on the realm, it is fine to call the algorithm here even if the [=service worker/global object=] may not be ready.

1. Return the result of [=building a URL pattern from a Web IDL value=] |rawPattern| given |baseURL|.
</section>

<section algorithm>
Expand All @@ -3379,7 +3376,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. If |condition|["{{RouterCondition/urlPattern}}"] [=map/exists=], then:
1. Let |rawPattern| be |condition|["{{RouterCondition/urlPattern}}"].
1. Let |pattern| be the result of running the <a>Parse URL Pattern</a> algorithm passing |rawPattern| and |serviceWorker|. If this throws an exception, catch it and return false.
1. If |pattern| [=URLPattern/has regexp groups=], then return false.
1. If |pattern| [=URL pattern/has regexp groups=], then return false.

Note: Since running a user-defined regular expression has a security concern, it is prohibited.

Expand Down

0 comments on commit e89eaed

Please sign in to comment.