Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Cache algorithm contains orphaned 'f' references #1280

Closed
inexorabletash opened this issue Feb 21, 2018 · 2 comments
Closed

Query Cache algorithm contains orphaned 'f' references #1280

inexorabletash opened this issue Feb 21, 2018 · 2 comments

Comments

@inexorabletash
Copy link
Member

If fieldValue matches "*", or the combined value given f and cachedRequest’s header list does not match the combined value given f and request’s header list, then:

f is never defined anywhere. From context, I assume it's fieldValue.
ewilligers pushed a commit to ewilligers/ServiceWorker that referenced this issue Feb 22, 2018
@ericwilligers
Update orphaned references in Query Cache algo
a02e52d 
Query Cache algorithm contains orphaned 'f' references.
Replaced with references to 'fieldValue'.

resolves w3c#1280
@ewilligers ewilligers mentioned this issue Feb 22, 2018
Closed
@jungkees
Copy link
Collaborator

Thanks for spotting this. I missed it in c8ab714.

@jungkees
Copy link
Collaborator

They should be replaced by fieldValue, and we're working on #1281.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update orphaned references in Query Cache algo ewilligers/ServiceWorker
2 participants
@inexorabletash @jungkees