Partition service workers using Storage Key. (#1606) #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanderview
commented
Mar 8, 2022
| @@ -3014,7 +3033,9 @@ spec: rfc7231; urlPrefix: https://tools.ietf.org/html/rfc7231 | |||
| 1. Else: | |||
| 1. If |request|'s [=request/url=] is not a <a>potentially trustworthy URL</a>, return null. | |||
| 1. If |request| is a <a>navigation request</a> and the <a lt="navigate">navigation</a> triggering it was initiated with a shift+reload or equivalent, return null. | |||
| 1. Set |registration| to the result of running <a>Match Service Worker Registration</a> algorithm passing |request|'s [=request/url=] as the argument. | |||
| 1. [=Assert=] |reservedClient| is not null. | |||
There was a problem hiding this comment.
There is a check for null reservedClient above, but I don't understand when that can happen. And we don't have a way to get the storage key without a client. Any thoughts on best thing to do here?
|
@jakearchibald PTAL. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff