Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why unrestricted double for acceleration readings? #23

Closed
dontcallmedom opened this issue Sep 15, 2017 · 3 comments · Fixed by #25
Closed

Why unrestricted double for acceleration readings? #23

dontcallmedom opened this issue Sep 15, 2017 · 3 comments · Fixed by #25

Comments

@dontcallmedom
Copy link
Member

When the spec was switched from separate reading interface to include it in the main one, the types of the x, y, z attributes were switched to **unrestricted** double - what is the reasoning behind the change? I didn't find anything related to Infinity in the spec, nor did I easily find any supporting model consideration in the generic sensor spec, nor in the motion sensors spec.

if there is a good reason, I think it should be documented, possibly in the 3 docs; if there isn't,

@alexshalamov
Copy link

@dontcallmedom Good point, there are no practical reasons to keep unrestricted double, as there are no sensors that could measure physical properties of +-Infinity magnitude. We should use double.

@pozdnyakov wdyt?

@pozdnyakov
Copy link

Think it was supposed to mean "unset value" but now the reading properties are nullable so no need to keep them unrestricted.

@pozdnyakov
Copy link

Think same applies to other concrete sensor classes (Gyroscope, Magnetometer, ..)

alexshalamov pushed a commit to alexshalamov/accelerometer that referenced this issue Sep 21, 2017
alexshalamov pushed a commit that referenced this issue Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants