Align reference frame definition #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
approved these changes
Feb 7, 2018
index.bs
Outdated
| @@ -181,7 +181,7 @@ and towards the viewer (see figure below). | |||
| The main difference between the [=device coordinate system=] and the [=screen coordinate system=], | |||
| is that the [=screen coordinate system=] always follows the [=dom screen=] orientation, | |||
| i.e. it will swap X and Y axes in relation to the device if the [=current orientation type=] | |||
| changes. In contrast, the [=device coordinate system=] will always remain the same. | |||
| changes. In contrast, the [=device coordinate system=] will always remain stationary. | |||
alexshalamov
force-pushed
the
align_coordinate_system_definitions
branch
from
8cab191
to
a07fa6b
Compare
anssiko
reviewed
Feb 7, 2018
| @@ -154,7 +154,7 @@ Reference Frame {#reference-frame} | |||
| ---------------- | |||
|
|
|||
| The reference frame for the sensor classes defined in this specification, | |||
There was a problem hiding this comment.
Sorry for the late review. Would this be a simpler way to specify the same:
The [=local coordinate system=] represents the reference frame for the [=readings=].
It can be either the [=device coordinate system=] or the [=screen coordinate system=].
There was a problem hiding this comment.
Updated the comment above to not make "reference frame" a dfn since we use the standard definition of the term https://en.wikipedia.org/wiki/Frame_of_reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff