Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying "text node" definition (step 2G) #212

Open
rahimabdi opened this issue Oct 26, 2023 · 1 comment
Open

Clarifying "text node" definition (step 2G) #212

rahimabdi opened this issue Oct 26, 2023 · 1 comment
Assignees
Milestone

Comments

@rahimabdi
Copy link

rahimabdi commented Oct 26, 2023

In "4.3.2 Computation steps", Step 2G of the name computation algorithm states:

G. Text Node: Otherwise, if the current node is a Text Node, return its textual contents.

Although a "Node" definition is provided, it's not made explicit what a "text node" is. I would propose adding more documentation, e.g.,:

Other sections that would need updating with linked "node" references:

  • 4 Name and Description
  • 4.3 Text Equivalent Computation

Further clarification from @cookiecrook and additional context for why this is being recommended in web-platform-tests/wpt#42407 (comment):

These are inherited from XML/DOM terms: most commonly text node versus element node versus comment node. Element nodes can be empty or contain other element, comment, and text nodes, but IIRC text nodes and comment nodes are always leaf nodes.

@rahimabdi rahimabdi changed the title Clarifying "text node" definition in AccName (step 2G) Clarifying "text node" definition (step 2G) Oct 26, 2023
@spectranaut spectranaut added this to the 2023H2 milestone Nov 2, 2023
@jnurthen
Copy link
Member

jnurthen commented Nov 2, 2023

Competing text node definitions:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants