handling fallback content for the meter element #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #27 this PR looks to treat the fallback content (the subtree) of the meter element as `aria-valuetext`. However, an author updates the value of the meter element, but does not update the subtree/fallback content, then the `value` needs to instead take preference over the fallback content, as the fallback contnet would no longer represent the true value of the `meter` element.
cookiecrook
reviewed
Feb 28, 2023
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
|
TODO: browser bugs need to be filed
|
|
FYI, my suggested placeholder text "[text content? innerText? computed |
scottaohara
commented
Oct 18, 2023
cookiecrook
reviewed
Nov 4, 2023
| <td> | ||
| <td class="comments"> | ||
| <div> | ||
| If the `meter` element's subtree contains text content, user agents SHOULD expose this content, along with the element's initial value, by exposing the fallback content via the <a class="core-mapping" href="#ariaValueText">`aria-valuetext`</a> mapping. |
There was a problem hiding this comment.
element's subtree contains text content, user agents SHOULD expose this content
Should this use "text node"?
Or innerText?
along with the element's initial value, by exposing the fallback content
I dunno what this means... Does this mean concat the innerText and aria-valuenow, or convert aria-valuenow to a percentage and then concat? Does "along with" mean prepend? append? join(", ")?
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #27
this PR looks to treat the fallback content (the subtree) of the meter element as
aria-valuetext.However, an author updates the value of the meter element, but does not update the subtree/fallback content, then the
valueneeds to instead take preference over the fallback content, as the fallback contnet would no longer represent the true value of themeterelement.Feedback / changes welcome.
Preview | Diff