Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use accumulated text that is not empty #112

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Only use accumulated text that is not empty #112

merged 1 commit into from
Jan 13, 2022

Conversation

kasperisager
Copy link
Contributor

@kasperisager kasperisager commented Feb 19, 2021

This seemed like the simplest way to resolve #72.


Preview | Diff

Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Thank you for your PR. 👍

Copy link
Contributor

@accdc accdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MelSumner MelSumner merged commit 650b15e into w3c:main Jan 13, 2022
github-actions bot added a commit that referenced this pull request Jan 13, 2022
SHA: 650b15e
Reason: push, by @MelSumner

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aria-label and aria-labelledby are inconsistent when they point to a blank label
3 participants