Update to Condition for step 2C #90

OisinNolan · 2020-08-28T16:42:27Z

This PR broadens the condition for step 2E such that it applies to controls embedded in nodes that allow name from content as well as controls that are embedded in labels.
Embedded in label and Embedded in node that allows name from content may then be merged and simplified to descendant of node whose accessible name / description is being computed, as is done in the PR.

This PR is motivated by the fact that many (all?) AccName implementations interpret step 2E in this manner. See example:

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on May 16, 2021, 3:07 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL


😭  Sorry, there was an error generating the HTML. Please report this issue!
Specification: https://rawcdn.githack.com/OisinNolan/accname/beeb3d59364035373d642da35b6a6dc4e3bf323d/index.html?isPreview=true&publishDate=2021-05-16
ReSpec version: 25.6.0
File a bug: https://github.com/w3c/respec/
Error: Error: Evaluation failed: Timeout: document.respec.ready didn't resolve in 27421ms.
    at ExecutionContext._evaluateInternal (/u/spec-generator/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:221:19)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async ExecutionContext.evaluate (/u/spec-generator/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:110:16)
    at async generateHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:276:12)
    at async toHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:92:18)
    at async Object.generate [as respec] (/u/spec-generator/generators/respec.js:14:44)
    at async /u/spec-generator/server.js:205:44

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Preview | Diff

MelSumner · 2021-05-16T15:08:12Z

@jnurthen please add to next week's agenda.

jnurthen · 2021-05-16T15:36:29Z

Next meeting is on 27 may. No meeting this week due to GAAD.

index.html

remove extra space

index.html

Remove blank line added in merge conflict resolution

index.html

remove extra space added in merge conflict resolution

MelSumner · 2022-03-16T22:40:37Z

index.html

              <ul>
                <li>If the embedded control has role <a class="role-reference" href="#textbox">textbox</a>, return its value.</li>
+                <li>If the embedded control has role menu <a class="role-reference" href="#button">button</a>, return the text alternative of the button.</li>


Suggested change

<li>If the embedded control has role menu <a class="role-reference" href="#button">button</a>, return the text alternative of the button.</li>

<li>If the embedded control has role <a class="role-reference" href="#menu">menu</a>, return the text alternative of the button that controls the menu.</li>

Since there's no role "menu button" I think this sentence might be a bit more accurate. WDYT?

MelSumner · 2022-03-16T22:41:37Z

Also @accdc I think I have resolved the merge conflicts so this is probably ready for you to review. 👍

accdc

Looks good to me. :)

cookiecrook · 2023-10-05T17:54:20Z

index.html

@@ -305,9 +305,10 @@ <h4>Computation steps</h4>
                </pre>
              </details></div>
            </li>
-            <li id="step2C">Otherwise, if the <code>current node</code> is a control embedded within the label (e.g. the <code>label</code> element in HTML or any element directly referenced by <code>aria-labelledby</code>) for another <a class="termref">widget</a>, where the user can adjust the embedded control's value, then return the embedded control as part of the text alternative in the following manner:
+            <li id="step2C">Otherwise, if the <code>current node</code> is an embedded control whose value can be adjusted by the user, and the <code>current node</code> is a descendant of an element whose <a class="termref internalDFN" href="#dfn-accessible-name" data-link-type="dfn">Accessible Name</a> or <a class="termref internalDFN" href="#dfn-accessible-description" data-link-type="dfn">Accessible Description</a> is being computed, then include the embedded control as part of the text alternative in the following manner:


adding whose value can be adjusted would remove readonly controls from the embedded control portion of the accname algo... I think this clause should be removed.

accdc · 2023-10-11T21:56:03Z

I agree, The text "whose value can be adjusted by the user" should be removed, and simply refer to control which will include all such variations.

jnurthen · 2023-11-03T23:07:04Z

How does this PR relate to #183 ?

OisinNolan added 2 commits August 28, 2020 16:54

Update made to the condition for step 2E

8ef6160

Re-worded

beeb3d5

jnurthen requested a review from accdc September 3, 2020 17:17

MelSumner changed the title ~~Update to Condition for step 2E~~ Update to Condition for step 2C May 16, 2021

MelSumner self-requested a review May 16, 2021 15:07

MelSumner added the Agenda label May 16, 2021

aleventhal approved these changes Jun 3, 2021

View reviewed changes

MelSumner removed the Agenda label Jun 9, 2021

Merge branch 'main' into step_2E_condition_update

7064c1b

MelSumner reviewed Mar 16, 2022

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

b061277

remove extra space

MelSumner reviewed Mar 16, 2022

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

f671130

Remove blank line added in merge conflict resolution

MelSumner reviewed Mar 16, 2022

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

b675a96

remove extra space added in merge conflict resolution

MelSumner requested changes Mar 16, 2022

View reviewed changes

accdc approved these changes Mar 17, 2022

View reviewed changes

cookiecrook requested changes Oct 5, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Condition for step 2C #90

Update to Condition for step 2C #90

OisinNolan commented Aug 28, 2020 •

edited by pr-preview bot

MelSumner commented May 16, 2021

jnurthen commented May 16, 2021

MelSumner Mar 16, 2022

MelSumner commented Mar 16, 2022

accdc left a comment

cookiecrook Oct 5, 2023 •

edited

accdc commented Oct 11, 2023

jnurthen commented Nov 3, 2023

	<li>If the embedded control has role menu <a class="role-reference" href="#button">button</a>, return the text alternative of the button.</li>
	<li>If the embedded control has role <a class="role-reference" href="#menu">menu</a>, return the text alternative of the button that controls the menu.</li>

Update to Condition for step 2C #90

Are you sure you want to change the base?

Update to Condition for step 2C #90

Conversation

OisinNolan commented Aug 28, 2020 • edited by pr-preview bot

💥 Error: 500 Internal Server Error 💥

MelSumner commented May 16, 2021

jnurthen commented May 16, 2021

MelSumner Mar 16, 2022

Choose a reason for hiding this comment

MelSumner commented Mar 16, 2022

accdc left a comment

Choose a reason for hiding this comment

cookiecrook Oct 5, 2023 • edited

Choose a reason for hiding this comment

accdc commented Oct 11, 2023

jnurthen commented Nov 3, 2023

OisinNolan commented Aug 28, 2020 •

edited by pr-preview bot

cookiecrook Oct 5, 2023 •

edited