Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 477 #490

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Issue 477 #490

wants to merge 2 commits into from

Conversation

evanp
Copy link
Collaborator

@evanp evanp commented Sep 5, 2018

Close issue #477 by including sec: namespace, used for HTTP signatures.

(Note: I accidentally referenced #447; I'll fix that when merged.)

@gobengo
Copy link
Contributor

gobengo commented Sep 12, 2018

Discussed in CG meeting today. @puckipedia raised a point that just adding the curie-prefix 'sec:' wouldn't be enough to make all the linked-data stuff work nicely

[16:55] <cwebber2> eprodrom: I realize that it does not also mean adding the aliases, I wonder if it's valuable to us to separate those two changes, first add the namespace then add the aliases, or must we do both simultaneously
[16:55] <cwebber2> puckipedia: I would like to point out there is a small issue with doing this and it is id values, eg sec:owner is id, so if you put a string in it it becomes a url
[16:55] <cwebber2> puckipedia: if you just use the prefix it doesn't do this
[16:57] <cwebber2> {"sec:publicKeyPem": "..."}
[16:57] <cwebber2> {"publicKeyPem": {"@type": "@id", "@id": "..."}}
[16:58] <puckipedia> {"sec:owner": "https://puckipedia.com/"} is either {"@value": "https://puckipedia.com/"} or an object {"id": "https://puckipedia.com/", "preferredUsername": "puckipedia"}

Conversatoin deferred but a good way to help would be to make a version of this PR that would resolve @puckipedia's concern.

Personally, I think that can be done separate from adding this curie prefix, which I support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants