Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate items in value tables #65

Closed
joanmarie opened this issue Apr 10, 2018 · 5 comments
Closed

Remove duplicate items in value tables #65

joanmarie opened this issue Apr 10, 2018 · 5 comments

Comments

@joanmarie
Copy link

joanmarie commented Apr 10, 2018

N.B. Edited because this issue was subsequently split into two as described in comments.

The actions table of values has duplicate (and in some cases triplicate) values. For instance brightness appears in the following rows (where the header row is row 1):

  • row 43: "brightness: change or show the settings for the brightness."
  • row 70: "brightness: adjust the screen or application brightness. Often used with increase or decrease but is sometimes used alone as a menu name or item."
  • row 76: "adjust the screen or application brightness. Often used with increase or decrease but is sometimes used alone as a menu name or item. EDITOR'S NOTE: At risk pending implemetions (sic)."

Other duplicates in actions:

  • channel (appears three times)
  • connect (appears two times)
  • loop (appears two times)
  • mediaPosition (appears two times)
  • temperature (appears three times)
  • volume (appears three times)

Duplicate in destination:

  • related (appears two times)

Extra row in field:

  • Beneath the bdayDay row, there is a row with the same description ("day of birthday") but no name value.
@clapierre
Copy link
Contributor

clapierre commented Apr 10, 2018 via email

@joanmarie
Copy link
Author

Would you be able to file these as two separate issues please in our GitHub repo issue tracker

Done. Issue #67

@joanmarie joanmarie changed the title Clean up actions table of values Remove duplicate items in Actions and Destinations tables Apr 10, 2018
@joanmarie
Copy link
Author

joanmarie commented Apr 10, 2018

Since I made a new issue for sorting, I edited the opening report and summary to make this issue just about duplicate items, and added a duplicate destination item.

@joanmarie joanmarie changed the title Remove duplicate items in Actions and Destinations tables Remove duplicate items in value tables Apr 10, 2018
@lseeman lseeman self-assigned this Mar 16, 2020
@lseeman
Copy link
Contributor

lseeman commented Mar 16, 2020

Thank you so much for your comment. We think the new draft has addressed it. We reduced the values or renamed where appropriate to remove duplicate names/values. See https://www.w3.org/TR/personalization-semantics-content-1.0/

@lseeman lseeman closed this as completed Mar 16, 2020
@clapierre
Copy link
Contributor

Here is a link to a sortable table to show the latest values has no duplicates.
https://raw.githack.com/w3c/personalization-semantics/rewrite-prototype/content/index.html#values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants