Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename symbol to adapt-symbol #235

Merged
merged 1 commit into from
Dec 8, 2022
Merged

rename symbol to adapt-symbol #235

merged 1 commit into from
Dec 8, 2022

Conversation

matatk
Copy link
Contributor

@matatk matatk commented Dec 3, 2022

Note: this only affects the Symbols module. The attribute name is found in
other files in the repo, but it does not look like we still use them.

@matatk
rename symbol to adapt-symbol
582b44e 
Note: this only affects the Symbols module. The attribute name is found in other fiels in the repo, but it does not look like we still use them.
ruoxiran
ruoxiran approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@ruoxiran ruoxiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, Matthew, it looks good to me.

@ruoxiran ruoxiran merged commit c7d5116 into main Dec 8, 2022
github-actions bot added a commit that referenced this pull request Dec 8, 2022
@matatk @github-actions
rename symbol to adapt-symbol (#235)
1fe6075 
SHA: c7d5116
Reason: push, by ruoxiran

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruoxiran ruoxiran ruoxiran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matatk @ruoxiran