Add link warning to bottom of page #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to warn people that clicking on links may not produce results at the moment, but may do so in the future. The aim is to reduce surprise and possible frustration when clicking on links to repos or pages doesn't produce relevant results. I'd like to retrofit this to all the new format lreq docs this week, if approved, so i'd appreciate a quick review.
✅ Deploy Preview for afrlreq ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@aphillips I could find your name in the Reviewers list. Could you also take a look, please? |
This is the CSS to show the link warning banner at the bottom of the page. (I forgot to add in the previous commit.)
|
LGTM. @xfq Can you add me to this repo? |
aphillips
approved these changes
May 14, 2024
xfq
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to warn people that clicking on links may not produce results at the moment, but may do so in the future. The aim is to reduce surprise and possible frustration when clicking on links to repos or pages doesn't produce relevant results.
I'd like to retrofit this to all the new format lreq docs this week, if approved, so i'd appreciate a quick review.
Preview