Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tidy] Fix bdi formatting #144

Closed
behnam opened this issue Sep 26, 2017 · 3 comments
Closed

[tidy] Fix bdi formatting #144

behnam opened this issue Sep 26, 2017 · 3 comments

Comments

@behnam
Copy link
Member

behnam commented Sep 26, 2017

Looks like the tidy tool coming with Mac does not allow overriding the type of a known tag, like bdi.

For the latest tidy development, I have filed an issue here: htacg/tidy-html5#616

If we want to get the right formatting with the existing tool, we have to replace our <bdi> usage with <span style="unicode-bidi: isolate;">.

@r12a
Copy link
Contributor

r12a commented Sep 26, 2017

If we want to get the right formatting with the existing tool, we have to replace our usage with .

Ouch. Much better would be <span dir="rtl/ltr">. We could add RLM/LRM for Edge.

Btw, for those numbers, do we actually need to isolate though?

@behnam
Copy link
Member Author

behnam commented Sep 26, 2017

Ouch. Much better would be . We could add RLM/LRM for Edge.

Wait, do we have a problem with Edge right now?

And, I'm not sure what solution you're suggesting here. Should we replace bdi with span tags? Would you please elaborate?

Btw, for those numbers, do we actually need to isolate though?

Yep, otherwise a list of ANs with commas in-between with result in an RTL list.

Another solution is to only list these in a table, in separate cells, instead of the running text.

behnam added a commit to behnam/alreq that referenced this issue Sep 26, 2017
This will get us the desired HTML output, at the cost of more verbose source.

See discussion here: w3c#144
@behnam
Copy link
Member Author

behnam commented Sep 26, 2017

Posted a stable solution here: #145

What do you think? Should we land that?

@r12a r12a added the editorial label Feb 20, 2019
@r12a r12a closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants