Add more examples and use Permission API #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
approved these changes
Oct 16, 2017
anssiko
requested changes
Oct 16, 2017
index.bs
Outdated
|
|
||
| als.onreading = () => { | ||
| let str = luxToWorkplaceLevel(als.illuminance); | ||
| if (typeof str !== 'undefined') { |
There was a problem hiding this comment.
Perhaps:
if (str) {
console.log(\`Light level is suitable for: ${str}.\`);
}
| return 'mechanical workshops, drawing, supermarkets'; | ||
| } else if (lux > 1000 && lux < 5000) { | ||
| return 'detailed drawing work, visual tasks of low contrast'; | ||
| } |
There was a problem hiding this comment.
Perhaps good to explicitly return here (with and without will return undefined):
return;
alexshalamov
force-pushed
the
add_examples
branch
2 times, most recently
from
f5f515c
to
b7adc08
Compare
anssiko
approved these changes
Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #43
Preview | Diff