Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: "Navigate backwards to a pressed toggle button" (Toggle Button, Test 12, V23.12.14) #1030

Closed
jha11y opened this issue Jan 18, 2024 · 4 comments · Fixed by #1048
Closed
Assignees
Labels
feedback Issue raised by or for collecting input from people outside the core project team. vo

Comments

@jha11y
Copy link

jha11y commented Jan 18, 2024

Description of Behavior

For the Shift+J test, the output was "Run Test Setup, dimmed, button". One of the assertions was that the role was Button. The role was announced as button, but focus was on the wrong element. I got a conflict when I passed one assertion, but failed the other two. This was the same for all other Shift+J tests.

Test Setup

@jha11y jha11y added feedback Issue raised by or for collecting input from people outside the core project team. vo labels Jan 18, 2024
@mcking65
Copy link
Contributor

@mcking65 mcking65 self-assigned this Jan 25, 2024
@css-meeting-bot
Copy link
Member

The ARIA-AT Community Group just discussed Feedback: "Navigate backwards to a pressed toggle button" (Toggle Button, Test 12, V23.12.14).

The full IRC log of that discussion <jugglinmike> Subtopic: Feedback: "Navigate backwards to a pressed toggle button" (Toggle Button, Test 12, V23.12.14)
<jugglinmike> github: https://github.com//issues/1030
<jugglinmike> Matt_King: This is the one that's related to "shift J" when quicknav is on and focus didn't move
<jugglinmike> Joe_Humbert: Well, focus DID move when I pressed "shift J"--it just didn't move to the intended place
<jugglinmike> Matt_King: Did you check whether or not there was unexpected behavior?
<jugglinmike> Joe_Humbert: When I first went through the test, I passed one of the assertions (just one)--the assertion that said it was a button. That's because I did land on the button
<jugglinmike> Joe_Humbert: But it was the WRONG button, so I didn't know if it really passed
<jugglinmike> Joe_Humbert: The system considered it a "pass" when I passed two and failed one
<jugglinmike> Joe_Humbert: This happened when I looked at the conflicts. So maybe the wording for conflicts is specifically confusing
<jugglinmike> Joe_Humbert: The other part of that same issue is: the assertion says that focus lands on a button. Focus landed on a button, but it was the wrong button. Is that a failure?
<jugglinmike> [group reviews the test and the AT response]
<jugglinmike> Matt_King: It IS a little confusing
<jugglinmike> Matt_King: Maybe the "role" assertion should have passed
<jugglinmike> Matt_King: Are you suggesting that we should make a change to the test?
<jugglinmike> Joe_Humbert: I'm wondering if the tester knows the behavior is incorrect, but the assertion is satisfied, should the tester makes the assertion as "passing"?
<jugglinmike> Matt_King: I think it should pass
<jugglinmike> Joe_Humbert: Keep in mind that this is all dependent on how the test was constructed. If there happened to be some other element in that incorrect destination, then the "button" role would not have been spoken, and the assertion would have clearly failed
<jugglinmike> Matt_King: So it's clear that "B" is missing from the "button" test plan
<jugglinmike> Matt_King: Two things need to happen. I'm adding them to the issue itself as a to-do list
<jugglinmike> Matt_King: I'll assign this to me for now
<jugglinmike> Joe_Humbert: I'm glad I asked!

@mcking65
Copy link
Contributor

Agreed in Feb 28 meeting to add 'b' to both command and toggle button test plans.

@css-meeting-bot
Copy link
Member

The ARIA-AT Community Group just discussed Feedback: "Navigate backwards to a pressed toggle button" (Toggle Button, Test 12, V23.12.14).

The full IRC log of that discussion <jugglinmike> Subtopic: Feedback: "Navigate backwards to a pressed toggle button" (Toggle Button, Test 12, V23.12.14)
<jugglinmike> github: https://github.com//issues/1030
<jugglinmike> murray_moss: "b" is a quicknav command
<jugglinmike> Matt_King: "j" is kind of like "f" in JAWS, but they're not quite equivalent
<jugglinmike> Matt_King: "f" in VoiceOver only goes to text fields, making it more like "e" in JAWS and NVDA
<jugglinmike> murray_moss: Wouldn't this also require a change to the instructions for how to test?
<jugglinmike> James_Scholes: yes, the nice thing is that the new test format allows this succinctly
<jugglinmike> Matt_King: We're writing the instructions for the latest verison of MacOS
<jugglinmike> IsaDC: So we are adding "b" to command and toggle button?
<jugglinmike> Matt_King: Yes; I think it's relevant. I think it should work for toggle button
<jugglinmike> Matt_King: It truly is Apples choice whether they distinguish buttons and toggle buttons within quicknav
<jugglinmike> Matt_King: I will assign this to IsaDC. It has a comment from me which just has a "todo" item in it
<jugglinmike> Matt_King: I'll write a comment in the issue right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback Issue raised by or for collecting input from people outside the core project team. vo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants