Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setupScripts not working for menubar edit tests #74

Closed
spectranaut opened this issue Feb 22, 2020 · 6 comments
Closed

setupScripts not working for menubar edit tests #74

spectranaut opened this issue Feb 22, 2020 · 6 comments
Assignees
Labels
tests About assistive technology tests

Comments

@spectranaut
Copy link
Contributor

No description provided.

@spectranaut spectranaut self-assigned this Mar 2, 2020
@zcorpan zcorpan added the tests About assistive technology tests label Mar 11, 2020
@spectranaut
Copy link
Contributor Author

Hey @jongund I just was taking a peak at this, and I notice there is a problem with the generation script! You can see in this test file, "testPageDocument" should be just "document".

this line of the script

Additionally, that script does do as it describes, it doesn't open the submenu and put the focus on the right place. You might have to stimulate a key event to get the behavior we want.

@spectranaut
Copy link
Contributor Author

wow I am now reviewing the PR where you already caught that bug :) Can we close this issue now?

@spectranaut
Copy link
Contributor Author

Actually, it looks like the menubar-editor still has this bug, but in the combobox test's setup script they are called "testPageDocument" -- so either references to "document" should become "testPageDocument" or the other way around!

@jongund
Copy link
Contributor

jongund commented Mar 18, 2020

@spectranaut
I am working on rewriting the menubar example to make it work with setup script.
It is in a separate branch.
The updated example would also be used in the aria practices.

@jongund
Copy link
Contributor

jongund commented Mar 18, 2020

@spectranaut

You can close this if you want, I think the problem is with the how the examples are written,

@zcorpan
Copy link
Member

zcorpan commented Apr 15, 2020

Closing

@zcorpan zcorpan closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests About assistive technology tests
Projects
None yet
Development

No branches or pull requests

3 participants