Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrictReferences leaves behind extra empty <dt> elements #8

Closed
AmeliaBR opened this issue Apr 8, 2018 · 0 comments
Closed

restrictReferences leaves behind extra empty <dt> elements #8

AmeliaBR opened this issue Apr 8, 2018 · 0 comments

Comments

@AmeliaBR
Copy link
Contributor

AmeliaBR commented Apr 8, 2018

The W3C pubrules checker is complaining to me about invalid HTML:

Element “dl” is missing a required instance of child element “dd”.

The immediate culprit seems to be the restrictReferences script in resolveReferences.js: It removes the <dd> definitions, and the <dfn> wrapping the term, but not the <dt>.

I'm not quite sure why there are redundant <dfn> inside <dt> in the first place, and maybe the person who wrote the script wasn't expecting them, either? I haven't taken the time to review the JS code, so I don't know how easy a fix it will be.

Regardless: all these empty <dt> elements are invisible in the final visual layout, but not to pubchecker & maybe not screenreader users.

michael-n-cooper pushed a commit that referenced this issue Apr 13, 2018
fixed up `dt` not being removed. fixes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant