Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft listbox design pattern #122

Closed
3 tasks done
mcking65 opened this issue Oct 16, 2016 · 5 comments
Closed
3 tasks done

Draft listbox design pattern #122

mcking65 opened this issue Oct 16, 2016 · 5 comments
Assignees
@jnurthen @accdc @mcking65 @annabbott
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.
Projects
Listbox Pattern and Examples Developm...
Milestone
1.1 2016Q4 PWD

Comments

@mcking65
Copy link
Contributor

mcking65 commented Oct 16, 2016 •
edited

The listbox pattern can be found at:
http://w3c.github.io/aria-practices/#Listbox

It is largely complete. Incomplete work includes:

  1. 2 links in the notes to sections that have not yet been drafted.
  2. There are several sentences that include "author should" language that should be revised to avoid normative sounding phrasing.

Requested reviews
@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. documentation labels Oct 16, 2016
@mcking65 mcking65 added this to the 1.1 Q4 PWD milestone Oct 16, 2016
@mcking65 mcking65 self-assigned this Oct 16, 2016
mcking65 added a commit that referenced this issue Nov 12, 2016
@mcking65
Listbox design pattern edits for issue #122
7cdb9f3 
Modified 'Listbox' section in aria-practices.html:
1. Replaced "author should" language in pattern description with language that states benefits of specific guidance.
2. Other pattern description edits for clarity.
3. Added paragraph to beginning of keyboard section stating that the guidance is for a vertical listbox.
4. Broke list items containing keyboard command descriptions for multiple keys into separate list items.
5. Corrected error in alternative selection moddle: shift+arrow toggles state rather than just selecting.
6. In keyboard notes, Added missing link to section describing the difference between focus and selection.
7. In keyboard notes, added missing link to section about using aria-activedescendant.
8. In keyboard notes, added note with link to section about deciding whether or not selection should follow focus.
9. In keyboard notes, added note about how behaviors change for horisontal listboxes.
10. In states and properties, added item about aria-orientation.
11. In examples, added link to example page and a brief description of the examples.
@mcking65
Copy link
Contributor Author

mcking65 commented Nov 12, 2016 •
edited

@jnurthen, @annabbott, @a11ydoer, @accdc
James, Jemma, Ann, Bryan,

The list of changes I made in the master branch to the
listbox pattern
for this issue are described in my statement for commit 7cdb9f3.

Given these are all editorial changes, I have committed them in master and not added a feedback link in the document itself. Nonetheless, I want to ensure multiple task force members have reviewed them before I close this issue. Please follow the above link to master in rawgit and have a look. Thanks!!

@accdc
Copy link

accdc commented Nov 21, 2016

The Listbox pattern looks good to me in the APG doc. I assume the Listbox demo though is still being worked on? It's not working at the moment in my browser.

@jnurthen
Copy link
Member

Matt, I suggest changing
When screen readers present a listbox, they render the name, state, and position of each option in the list.
to
When screen readers present a listbox, they may render the name, state, and position of each option in the list.
I'm not sure the position is always rendered by a screen reader - adding may provides the ability to not always render the position in the list.

@jnurthen
Copy link
Member

other than that looks good to me.

mcking65 added a commit that referenced this issue Nov 29, 2016
@mcking65
Clarify description of screen reader listbox presentation
7a3a0c5 
To address the Nov 28, 2016 comment by @jnurthen on issue #122,
modified aria-practices.html:
In the listbox pattern description, changed:
When screen readers present a listbox, they render the name, state, and position of each option in the list.
To:
When screen readers present a listbox, they may render the name, state, and position of each option in the list.
@annabbott
Copy link

Listbox Examples includes comment at top: "This example page is incomplete; it is not ready for review. When ready, feedback will be welcome in issue 123." Therefore I did not review the Examples page.

The APG page (http://w3c.github.io/aria-practices/#Listbox) looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnurthen jnurthen

@accdc accdc

@mcking65 mcking65

@annabbott annabbott

Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.
Projects
Listbox Pattern and Examples Developm...
  
Complete
Milestone
1.1 2016Q4 PWD
Development

No branches or pull requests
5 participants
@jnurthen @accdc @mcking65 @a11ydoer @annabbott